purescript-contrib/setup-purescript

Not working locally with act

Opened this issue · 6 comments

klarkc commented

I am trying to simulate the workflow locally with act, but I am getting this error:

[CI/build]   💬  ::debug::finished caching tool
| Cached path /opt/hostedtoolcache/spago/0.20.9/x64, adding to PATH
| Fetching psa
| [command]/usr/bin/sudo npm install -g purescript-psa@0.8.2
| sudo: npm: command not found

I tried the default config, and even adding

      - uses: actions/setup-node@v3
        with:
          node-version: latest
          cache: 'npm'

before uses: purescript-contrib/setup-purescript@main it still happens.

thomashoneyman commented

I haven’t used act before so I’m not sure how to solve this. We use NPM because GitHub’s runners have node by default, and therefore npm; if act doesn’t have that, then you’ll have to install it somehow

klarkc commented

I have no idea why, but this works:

name: CI

on:
  push:
    branches: [master]
  pull_request:
    branches: [master]

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3

      - uses: actions/setup-node@v3
        with:
          node-version: latest
          cache: 'npm'

      - run: npm install -g bats
      - run: bats -v

The only difference is the missing sudo 🤔 there is a reason for the sudo?

thomashoneyman commented

I can't remember why the sudo is there, although the explicit case statement on Windows vs. non-Windows makes me suspicious that there is a reason for it. I'm happy to remove it if it is not necessary.

klarkc commented

Yeah, 32fa32c adds the code block /src/Setup/GetTool.purs, but it's interesting to see that on Windows it uses npm without sudo. I'll try to change it and see what happens in a real linux runner.

andys8 commented

I encountered the same issue. I was trying to be a good citizen and run github action with act before opening a PR.
At the same time I'm wondering if this isn't more of an issue of act rather than this action. act is supposed to behave the same way a github runner would.

@klarkc Did you find something out regarding sudo?

| Fetching psa
| [command]/usr/bin/sudo npm install -g purescript-psa@0.8.2
| sudo: npm: command not found
[Publish Package/build]   ❗  ::error::The process '/usr/bin/sudo' failed with exit code 1
[Publish Package/build]   ❌  Failure - Main Setup PureScript
[Publish Package/build]   ⚙  ::add-path:: /opt/hostedtoolcache/purs/0.15.7/x64
[Publish Package/build]   ⚙  ::add-path:: /opt/hostedtoolcache/spago/0.20.9/x64
[Publish Package/build] exitcode '1': failure
[Publish Package/build] ⭐ Run Post Install pnpm
[Publish Package/build]   🐳  docker exec cmd=[node /var/run/act/actions/pnpm-action-setup@v2.2.4/dist/index.js] user= workdir=
| Pruning is unnecessary.
[Publish Package/build]   ✅  Success - Post Install pnpm
[Publish Package/build] 🏁  Job failed
Error: Job 'build' failed
klarkc commented

Nop. I'm guessing here, but I believe the origin of the bug is npm not being installed by default. Even so, the action should not rely in this npm. Because people normally use actions/setup-node which patches the user environment, and not the embeded npm. It hides a potential bug by using unexpected npm versions.