Add support for http2
Closed this issue · 14 comments
HTTP/2 is Stable in nodejs v10.10.0
I want this too. For rowtype-yoga/purescript-protobuf#34
Would http/2 be added to this repo, or would it be a separate repo?
I think keeping it in this repo would make updating the ecosystem that much easier since there's one less library to fix. I'd also imagine that some things are shareable between the two, but I'm not familiar with this area.
So would you be interested in a PR for a new module Node.HTTP2 in this repo?
Sure.
Do we want to add a spago.dhall to this repo?
I'd prefer we don't add a spago.dhall here. It makes doing breaking changes easier.
Can we add an Aff dependency to this repo for Aff modules?
The main constraint for Aff is that it only works on JavaScript backends. But Node.js also only works on JavaScript backends, so no new constraint will be introduced.
I think that's fine.
I think that's fine.
Great. Then I would also like to donate https://pursuit.purescript.org/packages/purescript-node-streams-aff/2.0.0 to purescript-node org and become a member of purescript-node org. Is that cool @JordanMartinez ?
I'm fine with you becoming a member. Let me check with others first.
I'm working on HTTP/2. I have a branch here which passes basic client/server tests for HTTP/2 and also includes an Aff API. https://github.com/jamesdbrock/purescript-node-http/tree/http2
I think that's fine.
Great. Then I would also like to donate https://pursuit.purescript.org/packages/purescript-node-streams-aff/2.0.0 to purescript-node org and become a member of purescript-node org. Is that cool @JordanMartinez ?
I've sent you an invite.