Remove bounds check and exception from Data.String.Unsafe foreign code?

Question

Remove bounds check and exception from Data.String.Unsafe foreign code?

Opened this issue 2 years ago · 3 comments

I think the bounds check and the exception are largely unnecessary. Presumably one would be using these APIs if they had already performed the requisite checks. If one wanted an exception (rather than undefined behavior), then there is unsafeJust on the safe API.

Answer 1 · 2024-05-01T17:37:10.000Z

I don't see Data.Char.Unsafe. Did you mean Data.String.Unsafe?

Answer 2 · 2024-05-01T17:38:15.000Z

Yes, sorry.

Answer 3 · 2024-05-01T17:44:07.000Z

This sounds good. Also, this will allow us to redefine char as export const char = charAt(0);.