purescript/purescript-strings

Deprecate count

NightRa opened this issue · 3 comments

The count function is a mistake, it should not have been exported and it's name is misleading.
Better deprecate it and afterwards unexport it.

Why is it a mistake?

It's an implementation detail I mistakenly renamed and then exposed.
Also, these have been issues here complaining about the naming; a function named count is expected to count the occurences in the whole String, not only it's prefix.

It just continued to sit in the back of my mind as an embarrassing mistake I made.

Ok, sounds good.