purescript/purescript-transformers

Change Eff to Effect in example

ursi opened this issue · 6 comments

ursi commented

The example for MonadCont uses Eff. I would put in a PR to change this except I still don't understand how this works, (partially because I don't know how Eff works so it's harder to figure out :p)

Eff (a :: SOMETHING | r) outputValue is the same as Effect outputValue.

This seems to be mostly done. The only other placed where Eff is used(?) is in the name of this module:

module Example.StateEff where

If this should be changed, I'll submit a PR. If not, then this issue should be closed.

@ursi Please submit a PR making this change.

ursi commented

@JordanMartinez Which change exactly? Someone has already changed the documentation for MonadCont. Are you asking me to change Example.StateEff as mhmdanas pointed out?

Ah... I didn't know that. I assumed someone would have updated this issue if they had done that.

I don't think the module name change is needed. What we gain isn't worth the time spent on it. I'm going to close this issue.

ursi commented

I actually currently have a different PR right now for this same documentation. I would have closed this issue earlier but I totally forgot about it.