purplediane/drop2

Add fixes for modernize/six also

Opened this issue · 3 comments

treyhunner commented

Shouldn't be too hard to make fixes that also fix things added by modernize (replacing various from six.moves lines with the Python 3 version for example).

This might actually be more useful since many packages out there use six.

WSLUser commented

Keep this project in mind: https://github.com/asottile/pyupgrade. You'll notice a large section in the README about six. Suggest you check that out first before putting time in that may not be needed.

treyhunner commented

Thanks @WSLUser! I hadn't seen that project.

It looks like it doesn't handle six.moves, though this library seems to: https://github.com/asottile/reorder_python_imports

Unfortunately that library also reorders imports which is a bit more than I hoped to do.

I may add some links to these in the README and try to complement pyugrade instead of re-implementing it.

  • 👍1
WSLUser commented

Yeah, that project isn't doing fixtures. Just rewrites code for changes needed. I have found it useful to use after using futurize (or modernize). Also keep in mind the issues they are working on to avoid duplicate effort.