pushbots/pushbots-react-native

Android build fails with new React Native 0.55.3 project

Closed this issue · 2 comments

lukebaker commented

I created a new React Native 0.55.3 project, added the pushbots-react-native module, made the Android changes listed in the README, and ran react-native run-android. I received the following error:

/tmp/blah/node_modules/pushbots-react-native/android/src/main/java/com/reactlibrary/RNPushbotsModule.java:53: error: cannot find symbol
       if(value != null && !value.isEmpty()){
          ^
  symbol:   variable value
  location: class RNPushbotsModule
/tmp/blah/node_modules/pushbots-react-native/android/src/main/java/com/reactlibrary/RNPushbotsModule.java:53: error: cannot find symbol
       if(value != null && !value.isEmpty()){
                            ^
  symbol:   variable value
  location: class RNPushbotsModule
2 errors
:pushbots-react-native:compileReleaseJavaWithJavac FAILED

FAILURE: Build failed with an exception.

FWIW, I also received this same error when attempting to integrate the pushbots library into an existing React Native 0.55.2 project.

Here's the method in question:

pushbots-react-native/android/src/main/java/com/reactlibrary/RNPushbotsModule.java

Lines 51 to 56 in 74fa343

@ReactMethod
public void trackEvent(String event_key){
if(value != null && !value.isEmpty()){
Pushbots.sharedInstance().trackEvent(event_key);
}
}

And here's where those lines were added: 74fa343

amrsobhy commented

thanks for reporting this. I have assigned this to one of our technical team and you can expect both a response and a fix before end of day. ​

AbdullahDiaa commented

Fixed in 1.0.6