Ship 1.6.2 to fix warnings
Closed this issue · 6 comments
New with Xcode 8 SocketRocket produces some warnings about unused results of functions:
This has been fixed in SocketRocket (at least by version 0.5.1). It also seems that, on master, SocketRocket has been updated to this new version, but since this update, there hasn't been a new version of libPusher.
Is it possible to ship a new 1.6.2 release so that this warning is fixed?
Thanks!
I should be able to get a release done on Monday.
Sorry about the delay - I've been away and unable to get a release done.
On 29 Aug 2016, 11:49 -0700, Keith Smiley notifications@github.com, wrote:
New with Xcode 8 SocketRocket produces some warnings about unused results of functions:
This has been fixed in SocketRocket (at least by version 0.5.1). It also seems that, on master, SocketRocket has been updated (
) to this new version, but since this update, there hasn't been a new version of libPusher.Line 17 in 1635beb
Is it possible to ship a new 1.6.2 release so that this warning is fixed?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (#229), or mute the thread (https://github.com/notifications/unsubscribe-auth/ACXEjlXRtmQSq8Smknp1gUn1RvWrKhkVks5qkymwgaJpZM4Jvxmb).
Thanks!!
Keith Smiley
On Sep 3, 2016, at 23:58, Hamilton Chapman notifications@github.com wrote:
I should be able to get a release done on Monday.
Sorry about the delay - I've been away and unable to get a release done.
On 29 Aug 2016, 11:49 -0700, Keith Smiley notifications@github.com, wrote:
New with Xcode 8 SocketRocket produces some warnings about unused results of functions:
This has been fixed in SocketRocket (at least by version 0.5.1). It also seems that, on master, SocketRocket has been updated (
) to this new version, but since this update, there hasn't been a new version of libPusher.Line 17 in 1635beb
Is it possible to ship a new 1.6.2 release so that this warning is fixed?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (#229), or mute the thread (https://github.com/notifications/unsubscribe-auth/ACXEjlXRtmQSq8Smknp1gUn1RvWrKhkVks5qkymwgaJpZM4Jvxmb).—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
1.6.2 has been pushed to cocoapods master 👍
Ah it turns out SocketRocket hasn't shipped a release since fixing these warnings either. So I guess it'll have to be the next time around.
I've asked about a potential release of SocketRocket here: facebookincubator/SocketRocket#466
Will publish a new version of libPusher if / when SocketRocket has a new release
Thanks!
Keith Smiley
On Sep 6, 2016, at 02:39, Hamilton Chapman notifications@github.com wrote:
I've asked about a potential release of SocketRocket here: facebookincubator/SocketRocket#466
Will publish a new version of libPusher if / when SocketRocket has a new release
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.