pusher/libPusher

[push notifications] Error callbacks?

Opened this issue · 3 comments

dingbat commented

Hi,

What's the plan on providing error callbacks via the delegate to PTNativePusher methods like registerWithDeviceToken, subscribe, and unsubscribe? I noticed right now it's just printing to the console, but this isn't helpful for a production app :)

Let me know if someone is working on it already or if it's tricky for some reason, but I'm willing to help out with it.

Thanks

hamchapman commented

Nothing particularly hard about it! Feel free to make a PR if you're up for it 👍

I've just made one for the Swift library (which works with Objective-C) here: pusher/pusher-websocket-swift#111

dingbat commented

That's great, thank you! In general Is the Swift library the one to use going forward since it also supports Obj-C?

hamchapman commented

No problem!

And yeah, we're definitely going to be quicker to add new features and fix bugs on the Swift library 👍