Tornado backend does not work with Tornado 5.x
zdexter opened this issue · 3 comments
zdexter commented
The deprecated alias tornado.concurrent.TracebackFuture has been removed.
from pusher.tornado import TornadoBackend
from tornado.concurrent import TracebackFuture
ImportError: cannot import name 'TracebackFuture'
zdexter commented
looks like the solution is to use tornado.concurrent.Future
:
.. versionchanged:: 5.0
This class was previoiusly available under the name
``TracebackFuture``. This name, which was deprecated since
version 4.0, has been removed. When `asyncio` is available
``tornado.concurrent.Future`` is now an alias for
`asyncio.Future`. Like `asyncio.Future`, callbacks are now
always scheduled on the `.IOLoop` and are never run
synchronously.
http://www.tornadoweb.org/en/stable/_modules/tornado/concurrent.html
WillSewell commented
Thanks for reporting this. Tornado 4.0 was released over 4 years ago now. I think we can drop support for earlier versions at this point. I'll create a PR to switch to tornado.concurrent.Future
.
WillSewell commented
The fix is in the latest release: v2.0.2