pushtorefresh/storio

Using StorIO with AndroidX and Jetifier

Closed this issue · 8 comments

We are converting one of our project to AndroidX and the jetifier seems to choke on the @NonNull annotation in the generated resolver (e.g., mapFromCursor(@NonNull ...)

When compiling we have Cannot find symbol on the NonNull symbol. This is probably because the jetifier did not convert com.android.support:support-annotations into androidx.annotation:annotation:1.0.0-alpha1 .

Anyone else ran into this as well?
Is there any will to migrate from the support libs to AndroidX?

I am facing the same issue and can't update to AndroidX because of this. Would be great to see the migration.

@RocketRider We still don't know if we'll patch+PR or migrate to another framework.

Hi guys!
Many sorry for delay
Jetifier rewrites binaries of third-party code, but it seems can't handle generated by this library classes =(
Hopefully I will publish both annotation types support in this weekend

Thanks @nikitin-da !
If you need help over the weekend, do not hesitate to ask =)

In the mean time, can some of you @fstephany or @RocketRider please create or link an existing ticket against Android Tooling team at b.android.com about codegen jetification?

I'd assume ButterKnife would have to go through similar problems recently, you might find discussions there, likely Jake has the answer/link

Thanks

Hi @artem-zinnatullin !
I saw butterknife issue. Jake says that it is tooling bug. There is issue in the tracker but with status new.
In the next butterknife release (v9.0) they will publish fix on the library side.

Thanks for links 👍

// It's amazing how many things they were able to break with this change, uhh

Nobody likes annotation processing =/