pvpgn/pvpgn-magic-builder

Error Visual C++ is Not Installed

thaison1995 opened this issue · 2 comments

thaison1995 commented

I have installed visual studio 2017, but when running build_pvpgn it doesn't recognize visual studio 2017, why is that
Untitled

HarpyWar commented

I can't reproduce the issue on fresh installation Windows 10 and VC++ 2017.

If it does not help show output from the following two commands:

module\tools\vswhere.exe
module\tools\vswhere.exe -products * -requires Microsoft.Component.MSBuild -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath

And check does file C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvars32.bat exist or not.

trungklam commented

In case other ppl might get the same issue. The root cause is that your VS need to install C++ build tool as well to be able to use magic builder. The below picture will help:
image
@HarpyWar can you please update the readme with that ? Thanks a lot