what if i dont want to open using exec
billybonks opened this issue · 5 comments
what if I want to open using child_process.spawn ?
I propose having a second method called getOpenCommand, so that I can execute the command in any way that I wish ? what are your thoughts ? i can make this change no worries.
I don't see any related activities in the referenced issue, are you going to support it? Since killing the processes in using the exec doesn't work in any platform, using the spawn is better.
sorry that commit got a bit tangled and was closed, we have been using this, which is based on this projects code https://github.com/poetic/ember-cli-cordova/blob/master/lib/utils/open.js. it just returns a string then we deal with the execution ourselves.
It means that you're not maintaining this project and I should be using ember, but that is a CLI project... Should I fork your project? I'm a little bit confused.
basically would like to mantain this project but return a have the option
of returning a string, (the command) insted of the lib executing it by
itself. if it can do that i will remove the open.js in our project and add
this as a dependency. asking for your opinion.
On Mon, Nov 10, 2014 at 11:03 AM, Arik notifications@github.com wrote:
It means that you're not maintaining this project and I should be using
ember, but that is a CLI project... Should I fork your project? I'm a
little bit confused.—
Reply to this email directly or view it on GitHub
#30 (comment).
Kind Regards
Sebastien Stettler
Sounds good to me. This is a good example for a little snippet that is genius and help everybody.
If it will return a string it would be great since it can be highly flexible. However you need to support those that already using this module and leave the "open" method as is and might consider adding another export for only returning the string representation.