Router / Extension - Remove or increase header size limit
Opened this issue · 0 comments
huntharo commented
Motivations
- Currently there is a hard limit on the size of headers that are parsed
- The limit is bad as it will break requests in an undefined way
Acceptance Criteria
- Consider removing the limit completely or making it configurable
- Add tests to see what happens when there are more headers than the limit allows
- Extension
- Router
Notes on Approach for the Router
- Function to be tested:
- Currently there are no
LambdaConnection.cs
direct tests (tested indirectly via other files) - Cases to implement:
- Send the header on the response to the extension (which contains the HTTP request for the extension to run) and validate that it arrives at the contained app with the correct and complete context
- Send the header on the simulated response from the extension and confirm that it is passed through the router back to the incoming request into the router
- 4 x 31 KB headers:
lambda-dispatch/extension/tests/lambda_service.rs
Line 1037 in 7f82820
- 1 x 64 KB header:
lambda-dispatch/extension/tests/lambda_service.rs
Line 1130 in 7f82820