py-pdf/pypdf_table_extraction

[Question] Should we enabling typing across the repo?

Opened this issue · 2 comments

justshrey commented

Hi,

I saw that there has been typing enabled in the PR (Add typing for camelot/backends) #12 for the backend. Wanted to know if we plan to do this across the repo? Happy to submit a pull request if that's something that we would like in the repo?

Am guessing it would be better to do this after merging existing pull requests and the work around rebranding?

bosd commented

Hi,
Yes I think it is good practice to do so.
As you mentioned, is it not the top priority yet. 😉

I'll welcome the pr.

  • 👍1
bosd commented

With this PR #190 , mypy type testing is added to github actions.

The strict option will not pass the tests.
But we can gradually work our way there. Bu activating more parameters in the toml file.