✨ Fix: packages page listing - many of the packages have missing maintainer
lwasser opened this issue · 6 comments
Right now the package listing on the website has a few issues. The fix for this specific repo will be to update the packages-grid.html file include to parse the maintainers listed in the new packages.yaml file - notice that each maintainer has a name and github username. we want the website to list the name (which we can get from github).
To complete this task you will need to do the following
- Update the packages.yml file in by running the parse_review_issues.py script here
- Update the packages.yml file created in that output in a pr in this repo. the file is here that you are updating
- Update the packages grid include file which uses liquid to ensure it's grabbing a list of maintainers from the maintainers field in the yaml.
The screenshot below shows the new maintainer section of the yaml that you can use to parse names. Note in the screen shot that name is empty. but we can add that using our metadata script in the near future:
This screenshot shows how now the maintainer name is sometimes "Name" and other times only one person when there is a maintainer team.
@lwasser In my working branch, I updated the file _data/packages.yml. There is also a packages.yml file at the root of the project directory. Should that be updated with the new packages data as well?
hi @bbulpett ! please only update the files in the _data/packages.yml directory. you can delete / remove the other packages and contributors.yaml file located in the root of the dir if you wish! many thanks!!
Hello @lwasser , apologies for the delay (post-PyCon jet lag) but I've created a PR for this issue here. Please let me know if changes are needed. Also, if I recall correctly, we discussed having each displayed maintainer name be a link to their GitHub profile. However, I didn't see it in the above issue description. I went ahead and made them links but, if that is in error, it's easy to revert and simply show the names.
Thanks again for the opportunity to contribute! 🙂
hi @bbulpett !! please don't apologize! i spent all weekend recovering from pycon :) i'll have a look at this today or tomorrow. and THANK YOU for another contribution!! 🎉