Fix tests
nils-herrmann opened this issue · 3 comments
nils-herrmann commented
pybliometrics version: 3.8
Code to reproduce the bug: $nosetests --verbose
Expected behavior: No errors or fails
List of tests that fail or have an error:
- pybliometrics.scopus.tests.test_AuthorRetrieval.test_affiliation_history ... ERROR
- pybliometrics.scopus.tests.test_AuthorRetrieval.test_estimate_uniqueness ... FAIL
- pybliometrics.scopus.tests.test_AuthorRetrieval.test_historical_identifier ... FAIL
- pybliometrics.scopus.tests.test_AuthorRetrieval.test_get_documents ... FAIL
- pybliometrics.scopus.tests.test_AuthorRetrieval.test_warning_without_forwarding ... ERROR
- pybliometrics.scopus.tests.test_AuthorRetrieval.test_warning_with_forwarding ... ERROR
- pybliometrics.scopus.tests.test_SerialTitle.test_citescoreyearinfolist ... FAIL
Michael-E-Rose commented
These are not bugs, they often mean that past commits broke something.
I have different fails though:
pybliometrics.scopus.tests.test_AuthorRetrieval.test_affiliation_history
fails because of pybliometrics/scopus/utils/parse_content.pypybliometrics.scopus.tests.test_CitationOverview.test_authors
fails for an unknown change, likely in the APIpybliometrics.scopus.tests.test_AuthorRetrieval.test_historical_identifier
fails because of a change in the APIpybliometrics.scopus.tests.test_SerialTitle.test_citescoreyearinfolist
fails because of a mistake in the test codepybliometrics.scopus.tests.test_PlumXMetrics
fails because of a change in the API
Also, when you're on Linux or Mac, you should use nosetests3
!
I will deal with the failues 2 through 5. Can you please fix the cause for the first failure, @nils-herrmann ?
Michael-E-Rose commented
Re my second point I reached out to the Scopus folks to verify that this no bug.
Michael-E-Rose commented
I updated all test scripts in 6023daf, but the first issue remains. I think the author information in the Citation Overview API is gone for good.