pybop-team/PyBOP

Correct RMSE to be mean square error not absolute square error

Closed this issue · 1 comments

Feature description

Cost function for root mean square error is calculating just root square error. Needs to be divided by n before square root to be rmse.

Julia reference.

Motivation

RMSE definition is incorrect

Possible implementation

No response

Additional context

No response

We use numpy.mean to capture the $1/n$ component of this cost function. Marking complete.