check=True isn't supported by run()

Question

check=True isn't supported by run()

sprt opened this issue 4 years ago · 1 comments

Currently, this can't be used as a drop-in replacement for subprocess.run() as passing check=True isn't supported directly. A simple fix would be to call check_returncode() manually on the returned CompletedProcess.

BTW, IMO subprocess_tee.run() should raise an error when it's passed unsupported arguments. This would avoid silent unexpected behavior.

Answer 1 · 2021-01-18T17:07:04.000Z

Correct, patch would be welcomed. I am happy to make a release after.