Check pre-commit ruff formatting for notebooks is set up correctly
Closed this issue · 1 comments
drbenvincent commented
I'm not 100% sure the pre-commit checks are fully/properly working for ruff formatting of notebooks. Currently we have:
CausalPy/.pre-commit-config.yaml
Lines 26 to 35 in 9a4daf7
Maybe we don't need nbQA
at all and solely use ruff-pre-commit
? The README at https://github.com/astral-sh/ruff-pre-commit shows that it's pretty simple to make it apply to Jupyter notebooks.
OriolAbril commented
It is not necessary to use nbqa, the latest ruff pre-commit hooks support jupyter and pyi files directly. The third code block shows how: https://github.com/astral-sh/ruff-pre-commit