pymc-labs/CausalPy

Improve visual appearance of tables in docs

Closed this issue · 8 comments

Under the new theme tables look like this
Screenshot 2024-06-26 at 13 20 12

and when the mouse hovers over a row, we get a highlight like this
Screenshot 2024-06-26 at 13 19 50

I think this is far from optimal. It would be good see what someone is capable of doing with custom css.

@drbenvincent can I work on this? How about making it match the CausalPy theme (blue and green) or just gray?

Hi @HarisMughal. Feel free to give it a go! I think a coloured highlight makes sense. If the current one is a theme option, maybe it makes sense to change that colour site wide?

The white/grey is good as a default row colour. But the lines/space between cells is very thin at the moment.

For Dark Mode
image
For Light Mode with new cell spaces
image

Code
`
html[data-theme="light"]{
--pst-color-table-row-hover-bg: #83db66;
--pst-color-secondary:#83db66;
}

html[data-theme="dark"] {
--pst-color-table-row-hover-bg: #093e60;
--pst-color-secondary:#093e60;
}

.table td ~ td, .table td ~ th, .table th ~ td, .table th ~ th{
border-left-width: 1.5px;
}`

Furthermore, I believe we need to revamp the whole theme as other items (buttons, search, hover) are still following default theme I tried to change color and looks really great and makes more sense! Have a look

image
image
Shall I report a new issue for this ? @drbenvincent

Any update? @drbenvincent

Sorry for the slow reply @Mark0047. I just want to get @OriolAbril 's opinion on editing the theme. We have a number of sites all using this theme so I want to check if specialising this one is going to cause headaches in the future?

Yes please would love to hear senior's analysis.

And shall I push the code for table?

To keep the theme consistent across libraries we have decided to abstract the theme configuration and then use that "custom theme", see #385.

So now the theme is here https://github.com/pymc-labs/labs-sphinx-theme and outside of my direct control. I think it makes most sense to either leave this, or propose a change on the new labs-sphinx-theme repo.