pypa/get-pip

Is monkeypatch_for_cert needed any more?

pfmoore opened this issue · 4 comments

pfmoore commented

Nowadays, pip extracts the cert bundle from certifi to a temporary file (see #pip/10753). As far as I can see, monkeypatch_for_cert here does basically the same thing.

Could we just remove that function?

pradyunsg commented

I think so. Someone can try this out, and ensure that it is indeed the case.

pfmoore commented

I might have a go at that if & when I can work out how I'd test such a change... But if anyone else gets to it first, I won't object 🙂

pradyunsg commented

FWIW, how to work on this repository for iterating on things like this:

  • Update the templates.
  • nox -s generate (regenerates the get-pip.py files)
  • nox -s check-3.9 (runs the relevant script in a clean venv)
pradyunsg commented

I think things should blow up -- certifi should fail, IIUC -- if removing the whole monkeypatching thing isn't something the code can handle. :)