Do not delete files that failed to download
benjaminws opened this issue · 1 comments
benjaminws commented
Currently if things fail, they fail and nothing is done to the remote. With this implementation: https://github.com/python/pypi-cdn-log-archiver/compare/refactor_write_logs_to_temp, we'll collect the failures and report them, but then proceed to delete them.
Preferred behavior would be to filter them out in https://github.com/python/pypi-cdn-log-archiver/blob/refactor_write_logs_to_temp/src/bin/pypi-cdn-log-archiver#L78
We could pass the failed logs to that function and easily filter them in the list comp. Although I question why I even bothered with the list comp here haha.
benjaminws commented
Addressed in #9