Support of Graph
Closed this issue · 0 comments
martinfleis commented
As a follow-up on #293, I checked what needs to happen elsewhere with this outcome:
Works with minor changes
- Geary #296
Works with minor refactor
Need a re-implementation or a fallback to W
- Gamma #326
- G_Local #326
- Geary_Local #296
- Geary_Local_MV #296
- Join_Counts #295
- Join_Counts_Local #295
- Join_Counts_Local_* #295
- LOSH #327
- Silhouettes #327
Not as great as I hoped for. I still think it won't be a too complex refactoring to support Graph in stuff like Gamma or Join_Counts but we'll need to be more invasive that I was in #293 to get a native support.
My main question is how acceptable is an internal fallback to W? For a reference, conversion of Queen contiguity of geoda.us_sdoh (72k polygons) to W takes 1.75 s ± 27.2 ms on my M1. Which is considerable, given that getting Moran takes 1.45 s ± 36.2 ms with Graph and 3.17 s ± 43.1 ms if I include to_W.