NumPy 2.0 - CI failures - AttributeError: `ptp`
jGaboardi opened this issue · 2 comments
jGaboardi commented
FAILED esda/tests/test_topo.py::TopoTester::test_isolation_options - AttributeError: `ptp` was removed from the ndarray class in NumPy 2.0. Use np.ptp(arr, ...) instead.
FAILED esda/tests/test_topo.py::TopoTester::test_isolation_valid - AttributeError: `ptp` was removed from the ndarray class in NumPy 2.0. Use np.ptp(arr, ...) instead.
FAILED esda/tests/test_topo.py::TopoTester::test_prominence_options - AttributeError: `ptp` was removed from the ndarray class in NumPy 2.0. Use np.ptp(arr, ...) instead.
FAILED esda/tests/test_topo.py::TopoTester::test_prominence_valid - AttributeError: `ptp` was removed from the ndarray class in NumPy 2.0. Use np.ptp(arr, ...) instead.
FAILED esda/tests/test_topo.py::TopoTester::test_to_elevation - AttributeError: `ptp` was removed from the ndarray class in NumPy 2.0. Use np.ptp(arr, ...) instead.
jGaboardi commented
So this was actually an issue over in libpysal.cg.voronoi.voronoi_regions() that was fixed several weeks ago, but is failing here in the Python 3.9 testing because that is pulling libpysal==v4.8.0.
Seems the actual fix here is the update the CI testing matrix by:
- dropping 3.8 & 3.9
- adding 3.12
Thoughts? I so, I'll open a fresh ticket for that.