cdflib version requirement an issue with PyHC Summer School HelioCloud setup
Closed this issue · 7 comments
Is your feature request related to a problem? Please describe.
Current version requirement is cdflib<0.3.20 which directly contradicts another PyHC package requirement, which, by memory, is cdflib>0.3.20.
Describe the solution you'd like
A more relaxed cdflib requirement.
Describe alternatives you've considered
Leaving pysatNASA out of demos, which would be a real bummer.
Additional context
Per brief discussion in developer meeting relaxing requirement may not be an issue.
The limit has been in place for a year, with multiple new versions of cdflib released. Going to test against new version.
Can't find the rationale for the cap, but I remember that 0.3.20 did not work. Using the latest creates errors in the omni hro instrument: https://github.com/pysat/pysatNASA/runs/6199105356?check_suite_focus=true
Update: it looks like 0.4.4 fixes the metadata issues documented in #95. Need to remove the bugfix here since the new cdflib loads meta as values, not arrays.
Note that versions below 0.4.4 do not fix this issue. For consistency, we would need to have this as a minimum or maximum version.
Based upon your report 0.4.4 should be a minimum. It is also compatible with the other package using cdflib with a req of >= 0.4.3
0.4.3 doesn't work here. We'd either have to set 0.4.4 as the minimum, or use a try-except for backwards compatibility