deprecate passing classes as hookspecs, it shold be instances
RonnyPfannschmidt opened this issue · 3 comments
we currently have self magic in place to handle unbound methods and passed in classes
ass signature (see #359) handles the bound methods so much better, we should ensure hook-specs are instances not types, and then generally handle them that way
followup to #359 (comment)_
Currently many hookspecs are actually modules... is the plan to force to move hookspec functions to methods of a class?
@nicoddemus modules will still be allowed, but passing classes would be disallowed, instead they'd have to be instances (orf control of method vs bound method
it may be permissible to allow types that don't take arguments
Currently we support modules, classes or instances, the plan is to support only modules or instances. Got it, thanks.