pytest-dev/pytest-splinter

Direct use of 'tmpdir' fixture causes warnings to be raised in latest pytest versions

jsfehler opened this issue · 11 comments

jsfehler commented

The following warning message appears after test runs:

RemovedInPytest4Warning: Fixture "tmpdir" called directly. Fixtures are not meant to be called directly, are created automatically when test functions request them as parameters. See https://docs.pytest.org/en/latest/fixture.html for more information.

jsfehler commented

The offending line is:

pytest-splinter/pytest_splinter/plugin.py

Line 279 in 63d8543

from _pytest.tmpdir import tmpdir

Simple fix would be reimplementing the function pytest uses to create tmpdir:

def _mk_tmp(request, factory):
    name = request.node.name
    name = re.sub(r"[\W]", "_", name)
    MAXVAL = 30
    name = name[:MAXVAL]
    return factory.mktemp(name, numbered=True)

@pytest.fixture(scope='session')
def session_tmpdir(request, tmpdir_factory):
    """pytest tmpdir which is session-scoped."""
    return _mk_tmp(request, tmpdir_factory)

Another path would be getting pytest to implement a session_tmpdir fixture.

richard-reece commented

Because of an interaction between the warning and pytest this causes all tests to error out. Thanks @jsfehler I've copied that code into my project's conftest to remove the failures from the warning and now my suite passes again.

  • 👍1
jsfehler commented

@youtux Are you working on something different/better for this issue? If not, I can open a PR with these changes.

youtux commented

I already started working on that, but I got preempted. I think by this weekend I will come up with a PR.

olymk2 commented

any update on this ?

youtux commented

There is an open PR at #116, but it has not been reviewed yet. I will ping the pytest-dev group again.

enkidulan commented

any progress on the issue? with pytest version 4 pytest-splinter is simply broken because of this issue...

mpasternak commented

@youtux thanks for the fix. I've also hit this bug today with clean pip install pytest-splinter.

... also, I know it's been only 23 hours since you committed the fix but... how about a release? :-) Thanks.

  • 👍1
Deleted user commented

I am getting this

request = <SubRequest 'session_tmpdir' for >
factory = TempdirFactory(_tmppath_factory=TempPathFactory(_given_basetemp=None, _trace=<pluggy._tracing.TagTracerSub object at 0x0000017C54111978>, _basetemp=None))

def _mk_tmp(request, factory):
    name = request.node.name

  name = re.sub(r"[\W]", "_", name)

E NameError: name 're' is not defined

youtux commented

@KevMuriithi can you post the full stack trace? Also the version of python, pytest and pytest-splinter you are using

youtux commented

@mpasternak I just release version 2.0.1 on PyPI. Happy testing!

  • 👍1