Duplicate tmpdir fixtures causes --fixtures sorting logic to fail

Question

Duplicate tmpdir fixtures causes --fixtures sorting logic to fail

martinpelikan opened this issue 8 years ago · 5 comments

It looks like something (recent) in pytest-splinter is creating a duplicate tmpdir fixture, and causes py.test --fixtures to fail when trying to sort the available fixtures.

I can't tell if this is due to something unique/incorrect in pytest-splinter, or if pytest itself should be made more robust.

Please see the details I filed in: pytest-dev/pytest#1651.

Answer 1 · 2016-06-27T13:55:18.000Z

https://github.com/pytest-dev/pytest-splinter/blob/master/pytest_splinter/plugin.py#L20 triggers this issue

importation of fixtures is always a bad idea

Answer 2 · 2016-07-12T11:51:30.000Z

@RonnyPfannschmidt
cool, but what exactly is the proposed solution then?

Answer 3 · 2016-07-12T14:43:38.000Z

@bubenkoff in that particular case for now use the tmpdir factory for pytest 3.1 we have a invocation scoped tmpdir fixture planned

Answer 4 · 2016-07-16T14:47:21.000Z

@martinpelikan please check with 1.7.4 which is just out

Answer 5 · 2016-07-19T19:34:06.000Z

@bubenkoff Confirmed working on 1.7.4, thanks!