pytest-dev/pytest-splinter

pytest 3.0 compatibility

pelme opened this issue · 1 comments

pelme commented

Running the 3.0 prerelease, pytest-splinter fails with:

__________________ ERROR at teardown of test_stupid_test[0] _________________

request = <SubRequest 'browser_screenshot' for <Function 'test_stupid_test[0]'>>, splinter_screenshot_dir = '<redacted>'
session_tmpdir = local('/private/var/folders/2w/bh7b385124b2wy0vkkcv0s9w0000gn/T/pytest-of-<redacted>'), splinter_make_screenshot_on_failure = True, splinter_screenshot_encoding = 'utf-8'
splinter_screenshot_getter_png = <function getter at 0x114d0ad70>, splinter_screenshot_getter_html = <function getter at 0x114d0ade8>

    @pytest.yield_fixture(autouse=True)
    def browser_screenshot(
            request, splinter_screenshot_dir, session_tmpdir, splinter_make_screenshot_on_failure,
            splinter_screenshot_encoding, splinter_screenshot_getter_png, splinter_screenshot_getter_html):
        """Make browser screenshot on test failure."""
        yield
>       for name, value in request._funcargs.items():
E       AttributeError: SubRequest instance has no attribute '_funcargs'

venv-2.7/lib/python2.7/site-packages/pytest_splinter/plugin.py:439: AttributeError

thanks for the report
can you please try pytest-latest-support branch, if it works or not
something wierd is going on with travis