python-control/Slycot

Subspace Identification (IB) routines

atisharma opened this issue · 2 comments

atisharma commented

I'm working on wrapping the subspace ID routines IB01AD, IB01BD, IB01CD, IB03AD, IB03BD.

I have IB01AD apparently working (though untested so far, and with some uncouth assumptions about the size of working arrays).
I'm unfamiliar with fortran, wrapping it in python and slycot, so please could someone review what I've done so far? Then I can fix any problems before I work on the other routines.

You can see the work at https://github.com/atisharma/Slycot/tree/identification (on a new branch). I will make a pull request if that is preferred.

bnavigator commented

Hi,

sorry for not getting back to you earlier. Work on adding these wrappers is much appreciated. Please open a pull request (instructions similar to #153 (comment)), as it is easer to review and we can see if it builds in the CI. It doesn't have to be perfect at the first commit, we can work it out over time.

atisharma commented

Thanks. I have some other things in the queue first, but will return to this and open a pull request.