python-discord/sir-lancebot

Bring back .bookmark text command

minalike opened this issue · 6 comments

Can we undeprecate the text command? The context menu/app command seems to inexplicably disappear from clients for some users, and when it does work, it also has the limitation of not working in read-only channels. I also think the original UX of the original .bm command was pretty nice, especially when replying to messages.

Relevant PR: #1211

I agree with Arl's suggestion to make this a slash command rather than text. Discord Link

and when it does work, it also has the limitation of not working in read-only channels.

Either way, you wouldn't be able to bookmark messages in read-only channels because you can't send text/slash commands there anyway.

and when it does work, it also has the limitation of not working in read-only channels.

Either way, you wouldn't be able to bookmark messages in read-only channels because you can't send text/slash commands there anyway.

the original text command would take any link as input. there is no way to provide input with a link in the current form.

I agree with Arl's suggestion to make this a slash command rather than text. Discord Link

Is #1211 in a state that a revert could be done until the work for a slash command is ready?

It's likely only the vocal few who used the command on a regular; however the lack of a reliable bookmark feature is missed.

Approved, anyone who wants to pick this up feel free to comment here.

The PR can't be directly reverted as it came with a number of refactor commits too.

I can take this.
Just to be clear, do we just want the same .bm implementation from before, without any changes? I feel like with the aforementioned refactoring commits the new code for the .bm command might not be 1:1 identical, so I want to check if that's alright.