Help command doesn't subclass `HelpCommand`
n0Oo0Oo0b opened this issue · 6 comments
Description
Lancebot's current help command doesn't subclass HelpCommand, unlike Python's. The former should be changed to match the latter because subclassing HelpCommand is the preferred way of creating custom help commands.
Reasoning
This wouldn't change anything for the end user, but internally, the bot will be able to do things like ctx.send_help(ctx.command)
Proposed Implementation
Replace Lancebot's help command with Python's new help command.
Additional Details
I think we should also consider moving the help command to bot-core instead because it is common functionality for all bots.
Would you like to implement this yourself?
- I'd like to implement this feature myself
- Anyone can implement this feature
This comment also mentions that changes to Python's help command should also be applied here, but the changes in python-discord/bot#519 (which refactored Python's help command to subclass HelpCommand) hasn't made it to Lancebot yet.
Isn't the better thing here having the help command logic in bot-core, which the two bots both then import and use? Then you don't have to worry about one bot being behind ahead/behind the other etc.. Fwiw, this is part of python-discord/bot-core#85,.
It's not a good idea have the same logic in two (or more) places, why don't move the logic to a common place? like a module?
Sorry, I didn't read your comment @TizzySaurus well. Yes, that is better.
Duplicate of #470