switch ArrayIndexer over to subclassing np.adarray

Question

switch ArrayIndexer over to subclassing np.adarray

Closed this issue 8 years ago · 2 comments

zingale commented 8 years ago

This will clean-up the code substantially, since I won't need to reimplement all the ufuncs.

A sample implementation of this is already done in the rk branch

Answer 1 · 2016-10-17T19:00:11.000Z

everything passes except for RT, which seems to have slight differences. Not sure why

Answer 2 · 2016-10-17T22:02:11.000Z

the RT bug was actually in master, in the way that the *= operator was working (or not working). In particular, this line in rt.py did not do what it was supposed to:

ymom *= dens

and this fix works as expected:

ymom.d[:,:] *= dens.d[:,:]

but now there is no need for the .d at all with the subclassing. So the new branch is cleaner and correct.