Better handling of escaping in regex patterns

Question

Better handling of escaping in regex patterns

sethmlarson opened this issue 6 years ago · 4 comments

Currently we erroneously accept \\ in the USERINFO_RE (and probably many more!) due to regex escaping acting differently when inside or outside of a character class.

Example: http://user\\@google.com shouldn't be a valid URL but is accepted by us.

Answer 1 · 2019-01-27T14:42:49.000Z

Can you add an example of this?

Answer 2 · 2019-01-27T16:11:43.000Z

Added a simple example.

Answer 3 · 2019-01-27T23:37:19.000Z

After looking at this more we do catch it when running the validator. Is this something that should only get caught at the validator stage or the parsing stage? Closing for now.

Answer 4 · 2019-01-28T00:24:22.000Z

That's a good question, @sethmlarson