python 3 error: `basestring` is still used by ropemode

Question

python 3 error: `basestring` is still used by ropemode

glyph opened this issue 5 years ago · 6 comments

I have been mostly happily using ropemode with Emacs, but today I set ropemacs-autoimport-modules and got a pymacs traceback because there's an isinstance(..., basestring) in the autoimport cache generation code path.

Answer 1 · 2019-07-18T23:00:05.000Z

Fixed in #16

Answer 2 · 2019-08-05T00:24:23.000Z

@soupytwist Thanks so much for the update! Any chance this will result in a PyPI release soon?

Answer 3 · 2019-08-05T00:24:47.000Z

(Also possibly worth noting, this furthers #8 along … :))

Answer 4 · 2019-08-05T19:44:25.000Z

I haven't released this one before myself, I can take a look at it unless @mcepl wants to.

Answer 5 · 2019-08-06T20:36:08.000Z

Fixed in #14 .

Answer 6 · 2019-08-10T23:30:37.000Z

Thanks @soupytwist, @mcepl !