python-social-auth/social-core

SOCIAL_AUTH_INACTIVE_USER_URL not working as expected

YPCrumble opened this issue · 2 comments

First, thank you for maintaining this library! Below is an issue we're experiencing that's potentially just an outdated mention in the docs, but wanted to see whether this isn't a bug. Also happy to make a PR if this is something that should be fixed.

Expected behaviour

I would expect a user who is logging in via social authentication (in my case Google) who has is_active set to False to be redirected to the URL set in SOCIAL_AUTH_INACTIVE_USER_URL when they try to login the next time. See the docs: https://python-social-auth.readthedocs.io/en/latest/configuration/settings.html

Actual behaviour

Currently nothing is happening. I also searched the python-social-auth codebase and it appears this setting isn't in effect currently, it's only shown in one test and in the docs, but nowhere else in the codebase: https://share.getcloudapp.com/Wnu77mJo

nijel commented

It is used here:

url = setting_url(backend, 'INACTIVE_USER_URL', 'LOGIN_ERROR_URL',
'LOGIN_URL')

Thank you!