python-trio/unasync

Add "# This file was automatically generated from ..." to generated code

pquentin opened this issue · 4 comments

This was originally python-trio/hip#35

One issue about this is that it's going to change all line numbers by one, which will impair debugging because it makes it harder to read sync tracebacks as if they were from the async code.

Since those generated files only end up in the installed package, is it important to add this comment? I'm not sure.

@pquentin

If the issue is actual: why not to add this lines at the end of the file? It would keep the line numbers...

@cdeler I can confirm now that keeping the line numbers is really important.

Adding this comment at the end is an interesting idea! I'm not sure who's going to see a line added at the bottom, but it doesn't hurt.

I'd accept a pull request that does that.

Thank you for your comment.

Let me try :-) It sounds interesting