python-visualization/branca

`scheme_info` wrong copy pasta

ajabep opened this issue · 1 comments

A copy pasta to initialize the scheme_info variable make it wrong.

branca/branca/utilities.py

Lines 134 to 135 in 52b10bd

with open(os.path.join(rootpath, '_cnames.json')) as f:
scheme_info = json.loads(f.read())

The copy-paste is wrong, not because of "a bad name for a variable", but because the content loaded is not the expected one. The file _cnames.json does not embed the wanted information in the following line:

if scheme_info[base_code] == 'Qualitative':

Fix

Replace by the right file.

 with open(os.path.join(rootpath, 'scheme_info.json')) as f: 
     scheme_info = json.loads(f.read()) 

Other comment

It may fix #104, python-visualization/folium#1270, but not sure, I have not tested.

It may fix #104, python-visualization/folium#1270, but not sure, I have not tested.

Ok. It's a bit more complicated (code never tested...). I'm trying to fix it and open a fancy PR.

@python-visualization / @BibMartin: Why put a maximum value for n at 253 @ branca/utilities.py:108 ?

maximum_n = 253