python/blurb_it

Allow adding "skip news"

jdemeyer opened this issue · 5 comments

jdemeyer commented

It would be nice if blurb_it could also add the skip news label for PRs where a NEWS item is not needed. For me, the missing skip news label is the most common reason why my CPython pull requests get the red cross.

methane commented

I think comitter should decide news is required or not.
I don't ignore PRs only because red cross.

  • 👍2
jdemeyer commented

I think comitter should decide news is required or not.

The committer should decide but PR author should be able to propose. Just like the committer decides what gets merged but the PR author proposes the patch.

I don't ignore PRs only because red cross.

Maybe you don't, but at least @willingc said "In other projects that I maintain, I rarely look at a PR that does not have a green checkmark" (https://discuss.python.org/t/github-labels-and-pr-review-workflow/237)

Mariatta commented

I personally think it is ok for non-committer to apply the skip news label to pass the CI.
If a core dev disagrees, it is quite easy to remove the label.

blurb-it (GitHub App) might not have the permission to add label. We might need to do this using bedevere's OAuth token.

Mariatta commented

Many docs-related PRs don't require news file. If a contributor just created a blurb file with not meaningful info, it is more difficult to remove the file (from within GitHub UI), but removing a label is easy.

  • 👍1
jdemeyer commented

This might be easier with bedevere: python/bedevere#175