python/python-docs-theme

Dark theme

vitaly-zdanevich opened this issue · 11 comments

vitaly-zdanevich commented

Please save our eyes. And batteries. Do not ignore this property of useragent https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

Cross-defect with https://bugs.python.org/issue39518

vitaly-zdanevich commented

I know about such extensions, but this is only for desktop browser. Youtube has dark theme, Google Calendar has dark theme on mobile - this is basic feature, dark theme is not for beauty - dark theme is against pain in eyes.

You need to add maybe 10 lines of CSS. I can do it if you approve me.

opensource-assist commented

@vitaly-zdanevich

I know about such extensions, but this is only for desktop browser. Youtube has dark theme, Google Calendar has dark theme on mobile - this is basic feature, dark theme is not for beauty - dark theme is against pain in eyes.

You need to add maybe 10 lines of CSS. I can do it if you approve me.

Why don't you do the PR on CPython's repo? The docs are served in there.

vitaly-zdanevich commented

But theme is in this repository.

septatrix commented

If you don't mind I'd like to work on this issue and make a pull request with some design drafts...

  • 👍1
septatrix commented

Just pushed a first draft if you want to take a look (#44)...

  • 👍3
  • 🚀3
flying-sheep commented

What’s missing before #44 will be merged?

hugovk commented

We're currently blocked due to lack of clarity whether we can use Sphinx 3 or need to keep support for 1.8:

#44 (comment)

AA-Turner commented

It was resolved to 3.2 (python/cpython#93337), though the pin to python-docs-theme==2022.1 should probably be introduced and backported to all non EOL versions, which are currently all unpinned (https://github.com/python/cpython/blob/3.7/Doc/requirements.txt#L18)

A

  • 🎉2
septatrix commented

I should have time to rebase the PR on the current master this weekend

  • 🎉3