python/release-tools

The add_to_python.org fails for some windows versions

pablogsal opened this issue · 4 comments

When adding files for some of the windows versions (32 bit installer and arm64) the add_to_python_dot_org.py script fails because the download button is set for those versions and that creates and schema conflict. This is the output;

Creating ReleaseFile object for python-3.11.0-arm64.exe 3110-Windows-installer-ARM64
Deleting previous release files
Created as id = 4111
Created as id = 4112
Created as id = 4113
Created as id = 4114
Sorry, this request could not be processed. Please try again later

Creating release_file failed: 500
Created as id = 4116
Created as id = 4117
Created as id = 4118
Sorry, this request could not be processed. Please try again later.

The problem is that this failure is silent :(

We should factor out this monster into the actual data instead of trying to guess:

download_button=(
("tar.xz" in rfile)
or ("macos11.pkg" in rfile)
or (
rfile.endswith((".msi", ".exe"))
and ("webinstall" not in rfile)
and (
((minor_version_tuple(release) >= (3, 9)) and ("amd64" in rfile))
or ("amd64" not in rfile)
)
)
),

CC @Yhg1s as this probably affected 3.12.0a1

Yhg1s commented

I did notice the installers were missing when I reviewed the Downloads entries. I added them manually. (I'm not sure if I needed to add anything else for the download button to work, but they show up correctly on the downloads page at least, and the download button doesn't matter for pre-releases anyway.)

(I'm not sure if I needed to add anything else for the download button to work, but they show up correctly on the downloads page at least, and the download button doesn't matter for pre-releases anyway.)

The issue here is that the script doesn't add them automatically and it should. The download button is only relevant in final releases but all releases are subjected to the schema, so that's why they fail anyway. The impact of this is the annoyance of having to add them manually, which defies the purpose of the script, especially since there are a growing number of fields per artifact.