[StatefulDataLoader] macOS tests are too slow
Closed this issue ยท 0 comments
andrewkho commented
๐ Describe the bug
test_state_dict is very slow on macOS (and slows down CI), likely because of macOS default multiprocessing_context being spawn instead of fork. The StatefulDataLoader tests on macOS take ~1.5 hours, vs 10 minutes on Linux and Windows.
Example of test-runtimes on my local mac:
![image](https://private-user-images.githubusercontent.com/5349063/326540821-8f881702-e812-4e2c-b61e-efac8596054b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1ODg1OTIsIm5iZiI6MTcyMDU4ODI5MiwicGF0aCI6Ii81MzQ5MDYzLzMyNjU0MDgyMS04Zjg4MTcwMi1lODEyLTRlMmMtYjYxZS1lZmFjODU5NjA1NGIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTBUMDUxMTMyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDQ3NGY5NzU1ZTYxNzk4YTg2NzYyM2ZlYmUyOGQ2NTcxMzY4YmJlOTJmMGJkMzg0ZjVmYjQ4ZGQ4Y2M2ZTU0NCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.r8b1cQv9ONuwxcp9wVYXeHGcwQWkUXOjajJT1ge4cog)
We should a) update CI to log test times, b) for macOS, drop some of the tests. Each test_mp* test runs 6x, and if we have coverage from Linux + Win then we probably don't need all of them for mac
Versions
Nightly