"Missing" platform abbreviation causes unexpected error when loading data array in Scene

[joleenf]

There is a split decision on aws between the NOAA-20 platform abbreviation (j01) and the NOAA-21 platform abbreviation (n21). An update to the platform name module, adding at least an "N21" key value pair would load the NOAA-21 data that is currently hosted on aws.

This is an example of 3 files names downloaded this morning.

JRR-CloudHeight_v3r2_j01_s202410010000061_e202410010001306_c202410010128034.nc
JRR-CloudHeight_v3r2_npp_s202410010000064_e202410010001306_c202410010155153.nc
JRR-CloudHeight_v3r2_n21_s202410010000067_e202410010001314_c202410010126402.nc

The yaml is built so that all the files are recognized as valid files for the viirs_edr.py reader. However, the "n21" abbreviation is missing in the platform_name code. Consequently, the three files can be loaded into the Scene, but trying to load datasets from the JRR-CloudHeight_v3r2_n21_s202410010000067_e202410010001314_c202410010126402.nc file fails. The failure indicates that the dataset ID is not in the Scene, but it seems that adding the "n21" key to the platform_names resolves this issue.

Expected behavior
After the NOAA-21 file is loaded, I expected that I could load the datasets it contained, such as "CldTopTemp". This can be verified as an expected dataset with scn.available_dataset_ids()

Code

import os
from satpy import find_files_and_readers, Scene
from satpy.utils import debug_on

debug_on()

base_dir = "/Users/joleenf/data/p2g/aws_test/"
filename = os.path.join(base_dir,
                        "JRR-CloudHeight_v3r2_n21_s202410010000067_e202410010001314_c202410010126402.nc")

# This shows that all the files are recognized as loadable from the viirs_edr reader.
files = find_files_and_readers(base_dir=base_dir)

print(files)

{'viirs_edr': ['/Users/joleenf/data/p2g/aws_test/JRR-CloudHeight_v3r2_n21_s202410010000067_e202410010001314_c202410010126402.nc', '/Users/joleenf/data/p2g/aws_test/JRR-CloudHeight_v3r2_npp_s202410010000064_e202410010001306_c202410010155153.nc', '/Users/joleenf/data/p2g/aws_test/JRR-CloudHeight_v3r2_j01_s202410010000061_e202410010001306_c202410010128034.nc']}

# Specfically load the "n21" file.
scn = Scene([filename], reader="viirs_edr")

# CloudTopTemp should be loadable
scn.load(["CldTopTemp"])

# However, this produces a KeyError (Unknown datasets)
scn["CldTopTemp"]

print(scn["CldTopTemp"].attrs["platform_name"])

KeyError: "Could not load DataID(name='longitude_jrr_cloudheight', resolution=750, modifiers=()) from any provided files"
[WARNING: 2024-10-23 11:10:25 : satpy.readers.yaml_reader] Failed to load DataID(name='CldTopTemp', resolution=750, modifiers=()) from <VIIRSJRRFileHandler: '/Users/joleenf/data/p2g/aws_test/JRR-CloudHeight_v3r2_n21_s202410010000067_e202410010001314_c202410010126402.nc'>
Traceback (most recent call last):
File "/Users/joleenf/Projects/polar2grid/satpy/satpy/readers/yaml_reader.py", line 712, in _load_dataset
projectable = fh.get_dataset(dsid, ds_info)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/joleenf/Projects/polar2grid/satpy/satpy/readers/viirs_edr.py", line 131, in get_dataset
data_arr = self._sanitize_metadata(data_arr, info)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/joleenf/Projects/polar2grid/satpy/satpy/readers/viirs_edr.py", line 162, in _sanitize_metadata
data_arr.attrs["platform_name"] = self.platform_name
^^^^^^^^^^^^^^^^^^
File "/Users/joleenf/Projects/polar2grid/satpy/satpy/readers/viirs_edr.py", line 203, in platform_name
return platform_dict[platform_path.upper()]
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'N21'

I propose just adding the additional key/value pair to resolve this issue

@property
    def platform_name(self):
        """Get platform name."""
        platform_path = self.filename_info["platform_shortname"]
        platform_dict = {"NPP": "Suomi-NPP",
                         "JPSS-1": "NOAA-20",
                         "SNPP": "Suomi-NPP",
                         "J01": "NOAA-20",
                         "N20": "NOAA-20",
                         "JPSS-2": "NOAA-21",
                         "J02": "NOAA-21",
                         "N21": "NOAA-21"}
        return platform_dict[platform_path.upper()]

However, I am not sure the additional SNPP and N20 are actually necessary. I have not recently seen these abbreviations on aws.

Environment Info:

• OS Sonoma 14.6.1
• Satpy Version: 0.49.1.dev134+g1bb320385.d20240802