qAp/gresearch_crypto_forecasting_kaggle

Dimension of x_affine missing a rank ?

Closed this issue · 1 comments

qAp commented

In time2vec, the dimension x_affine is stated in this comment:

gresearch_crypto_forecasting_kaggle/spacetimeformer/time2vec.py

Line 24 in cf6ad8a

# size of x_affine = [bs, sample, embed_dim]

Should the dimension be instead [bs, sample, input_dim, embed_dim]?

qAp commented

This has been corrected in the original spacetimeformer repo.