Doesn't support Environment Variable PORT

Question

Doesn't support Environment Variable PORT

Closed this issue 9 years ago · 5 comments

drusellers commented 9 years ago

Trying to use zk-web with foreman but doesn't support changing the port number based on environment variable.

Answer 1 · 2015-03-03T09:23:12.000Z

why not edit the config file?

Answer 2 · 2015-03-03T13:33:04.000Z

Short Answer: http://12factor.net/
:)

Also, foreman will pass a PORT environment variable to be used and it would be nice to be able to use foreman. Foreman, will also spit out upstart files, systemd files which makes running my tools much easier. I'm happy to contribute a change that will allow both the config file and the env var.

Answer 3 · 2015-03-05T04:34:18.000Z

it would be nice if u can contribute.

Answer 4 · 2015-03-05T15:19:08.000Z

Ok, cool beans. Are you ok if I pull in the environ package? https://github.com/weavejester/environ

Answer 5 · 2015-03-06T08:31:55.000Z

If it can be achieved by simply wrap System.getEnv(), don't introduce unnecessary external library.^_^