qjebbs/vscode-markdown-extended

Sometimes plantuml diagram doesn't export to PDF

leandro-costa opened this issue · 3 comments

I did some tests with the file and the diagram did not export to PDF.

I changed "page.setContent" for "page.goto" to a temporary file on "puppeteer.ts" and it worked

commit

Cannot reproduce, I test with the same file you provided, and it exported OK.

Use a tmp file will increase unnecessary disk writing, that is what I always try to avoid.

Can you test with This file and :

{"plantuml.server": "https://www.plantuml.com/plantuml"}

?

And don't run Markdown Extended in debug mode. Debug delay makes export work. run with extension downloaded from vscode marketplace.

I think is samething like this with object tag

Puppeteer waits until the network request is idle, but the PLantUML renders diagram with object tag, which is not count as a request of current document, I guess. I'll revert this commit: qjebbs/vscode-plantuml@7d85485 later.

No change is required with this extension.