The list of DDA experimental releases is not loading on Linux
adequacy1 opened this issue · 20 comments
Maintainer Edit
The only current solution for playing experimental on Linux is going to settings and setting "Number of releases to request" to a high number like 100, 500, This will make Catapult load more and thus older valid Linux releases.
There is nothing else we (Catapult) can do to actually fix this issue, CDDA tiles linux builds are currently broken upstream (check out CleverRaven/Cataclysm-DDA#74858 for more info).
Original post
The list of DDA experimental releases is not loading. Other versions of Cataclysm - the download works.
Linux version.
The same problem
Same issue on latest Manjaro and Ubuntu
The reason is that there are actually no releases since June 27th due to some build error. See this issue
Indeed, another release appeared today (2024-07-03-2146).
I tried to play the last experimental version on Windows PC, and it's better than last stable 0.G.... I need a quick fix for that... The bug reproduces only for CDDA, for CBN it works properly... I guess issue is minor...
The issue is based that substring of experimental builds doesn't exists at this moment for Linux platform:
"dda-experimental-linux": {
"field": "name",
"substring": "cdda-linux-tiles-x64", <-- doesn't exists in build names
# "substring": " cdda-linux-curses-x64" <-- not sure but i guess it's a correct one haven't tested, haven't work before with godot
}
Actually:
We have build names:
Substring: cdda-linux-tiles-x64
Field: cdda-android-bundle-2024-07-12-2131.aab
Substring: cdda-linux-tiles-x64
Field: cdda-android-x32-2024-07-12-2131.apk
Substring: cdda-linux-tiles-x64
Field: cdda-android-x64-2024-07-12-2131.apk
Substring: cdda-linux-tiles-x64
Field: cdda-linux-curses-x64-2024-07-12-2131.tar.gz
Substring: cdda-linux-tiles-x64
Field: cdda-osx-curses-universal-2024-07-12-2131.dmg
Substring: cdda-linux-tiles-x64
Field: cdda-osx-tiles-universal-2024-07-12-2131.dmg
Substring: cdda-linux-tiles-x64
Field: cdda-windows-tiles-sounds-x64-2024-07-12-2131.zip
Substring: cdda-linux-tiles-x64
Field: cdda-windows-tiles-sounds-x64-msvc-2024-07-12-2131.zip
Substring: cdda-linux-tiles-x64
Field: cdda-windows-tiles-x64-2024-07-12-2131.zip
Substring: cdda-linux-tiles-x64
Completed PR: #161 < --- please test
Tested: Game is not starting from Godot for last experimental release
Next point the last experimental release on official vebsite was
cdda-linux-tiles-x64-2024-06-26-1623.tar.gz
But the Catapult fetch last 10 releases which doesn't contain cdda-linux-tiles-x64 probably we should increase count of featched releases till 100 and display only 10 ones
I'll prepare another PR tomorrow :)
Fixed in #162 @AriaMoradi, @qrrk please review
Closed as count of releases to request can be changed in settings...
Closed as count of releases to request can be changed in settings...
What's the problem here?
@AriaMoradi the problem was that CDDA experimental releases wasn't loading for Linux systems, so I performed the investigation and opened couple of requests to fix that, than I understood that issue can be fixed just by increasing releases to fetch count in Catapult settings. So, I closed all opened PR's, and I guess the issue can be also closed.
The users are not gonna know that - you should make it default to some value that works.
The users are not gonna know that - you should make it default to some value that works.
Thanks, will create PR.
@failboat78, @qrrk, @AriaMoradi Created PR to fix issue #166
Why not just add an option to get the last 10 working releases if you're on Linux? Forcing the user to increase the fetch releases from 10 to 100 makes them wait for an increasingly long period of time for only two or so new releases. This shouldn't be all that difficult, however I'm not good with CPP and only ever touched C#, python and similar languages so I don't think I'd be able to do it myself.
Latest releases are working now. It still is rather odd that it counts every release instead of counting every OS/platform specific build.
If 100 releases fail for Linux specifically we wont be able to list anything on Catapult.
This comes down to GitHub API. As far as it is concerned, a release is anything that goes on the Releases page of a project, regardless of whether it has any artifacts for a given platform (or any artifacts at all, even). There is no way to request only releases relevant to a specific platform (and to my knowledge there is no way for project maintainers even to provide that information to the system).
CleverRaven/Cataclysm-DDA#74858 was closed, the issue is resolved now.
This comes down to GitHub API. As far as it is concerned, a release is anything that goes on the Releases page of a project, regardless of whether it has any artifacts for a given platform (or any artifacts at all, even). There is no way to request only releases relevant to a specific platform (and to my knowledge there is no way for project maintainers even to provide that information to the system).
Can't you get every release and check if it has 'linux' in its name?