data-cacheid aren't cleaned up before code snippets are taken

Question

data-cacheid aren't cleaned up before code snippets are taken

Closed this issue 9 years ago · 3 comments

I've been finding a lot of data-cacheid attributes in the code snippets returned by Quail. I think this is caused by the color tests. This may be confusing to users.

Answer 1 · 2015-07-07T03:21:00.000Z

Using elem.dataset or jQuery.data() should keep these out of the DOM.

Answer 2 · 2015-07-07T04:17:02.000Z

Tried using dataset but it threw TypeError: 'undefined' is not an object (evaluating 'element.dataset.cacheId') during testing.

Pretty sure I'm missing something obvious here, but the jQuery .data() method seems to work and gets rid of these data-cacheid attributes in reports.

Answer 3 · 2015-07-27T17:02:48.000Z

Fixed by PR #360 .