r1ch support
Opened this issue · 4 comments
Test and confirm protocol 37 works as expected, or create a separate protocol definition for it.
I would also suggest testing against the latest skullernet Q2Pro and the new protocol 38 being introduced in AQtion if it makes sense
https://github.com/skullernet/q2pro
https://github.com/actionquake/q2pro/tree/aqtion
Did some limited testing of Q2Pro here: #104
Do the changes to the protocol in AQtion modify the information sent to the master? I did some preliminary testing and heartbeats/pings seemed to work as expected.
The protocol changes should not have affected how the information gets sent, but we did reduce the amount of data being sent (consolidated game modes into a single field for example, rather than a unique integer field for each type)
I toyed with the idea of validating all the key/value pairs that get sent in a heartbeat against the protocol but decided against it. As at the time it felt like a step that adds additional complexity while potentially locking out edge cases, and I'm going for broad compatibility at the moment. Current the master just grabs everything and stores it in DynamoDB as a JSON blob.